netdev - Re: [PATCH v2 net 1/1] net sched actions: fix GETing actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b773a674-cbb6-4b87-8a78-95648ab848ea@mojatatu.com>
Date:   Mon, 12 Sep 2016 16:51:03 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net 1/1] net sched actions: fix GETing actions

On 16-09-12 01:18 PM, Cong Wang wrote:
> On Mon, Sep 12, 2016 at 3:21 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:


>> +               if (ovr)
>> +                       a->tcfa_refcnt-=1;
>
> How about tcfa_bindcnt?

We dont touch it when mucking around only with actions (as is in
this case).


>> +       }
>> +}
>> +
>>  int tcf_action_init(struct net *net, struct nlattr *nla,
>>                                   struct nlattr *est, char *name, int ovr,
>>                                   int bind, struct list_head *actions)
>> @@ -612,8 +622,15 @@ int tcf_action_init(struct net *net, struct nlattr *nla,
>>                         goto err;
>>                 }
>>                 act->order = i;
>> +               if (ovr)
>
> Need to check this boolean? It looks like we need this for !ovr case too?
>

They are fine if they didnt exist.

I will fix the coding style issues and submit.

cheers,
jamal