netdev - Re: [PATCH v5 net-next 1/1] net_sched: Introduce skbmod action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99274ae5-4f40-fc08-3d35-9b2fe7f792b5@mojatatu.com>
Date:   Mon, 12 Sep 2016 19:56:31 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, daniel@...earbox.net,
        xiyou.wangcong@...il.com, john.r.fastabend@...el.com
Subject: Re: [PATCH v5 net-next 1/1] net_sched: Introduce skbmod action

On 16-09-12 07:40 PM, Eric Dumazet wrote:
> On Mon, 2016-09-12 at 19:30 -0400, Jamal Hadi Salim wrote:
>> From: Jamal Hadi Salim <jhs@...atatu.com>
>
>> +
>> +static struct tc_action_ops act_skbmod_ops = {
>> +	.kind		=	"skbmod",
>> +	.type		=	TCA_ACT_SKBMOD,
>> +	.owner		=	THIS_MODULE,
>> +	.act		=	tcf_skbmod_run,
>> +	.dump		=	tcf_skbmod_dump,
>> +	.init		=	tcf_skbmod_init,
>> +	.walk		=	tcf_skbmod_walker,
>> +	.lookup		=	tcf_skbmod_search,
>> +	.size		=	sizeof(struct tcf_skbmod),
>> +};
>
> Looks like you missed a .cleanup() handler ?
>
> Otherwise, d->skbmod_p wont be freed .
>
>
>

Yes, I did ;->
Another version coming. Is there a good way to catch
something like this (ala userspace valgrind)?

cheers,
jamal