netdev - Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2016 14:55:15 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Colin King <colin.king@...onical.com>,
        Chas Williams <3chas3@...il.com>,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source
 formatting

Hello.

On 9/12/2016 12:29 PM, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> The newline escape is incorrect and needs fixing. Also adjust source
> formatting / indentation and remove trailing white space.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/atm/iphase.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index 9d8807e..256b191 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
>                  if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
>                      return ret;
>                  }
> -       }
> -	else
> -           printk("iadev:  Non UBR, ABR and CBR traffic not supportedn");
> +	} else
> +		printk("iadev:  Non UBR, ABR and CBR traffic not supported\n");

    All branches of the *if* statement should have {} if at least one has 
them, perhaps a material for a follow-up patch).

[...]

MBR, Sergei