netdev - Re: [RFC 08/11] Add support for data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40a9df9e-a0aa-9020-c523-6042baf729d1@grimberg.me>
Date:   Tue, 13 Sep 2016 17:32:13 +0300
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Ram Amrani <Ram.Amrani@...gic.com>, dledford@...hat.com,
        davem@...emloft.net
Cc:     Yuval.Mintz@...gic.com, Ariel.Elior@...gic.com,
        Michal.Kalderon@...gic.com, rajesh.borundia@...gic.com,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [RFC 08/11] Add support for data path



> +	pbe = (struct regpair *)pbl_table->va;
> +	num_pbes = 0;
> +
> +	for (i = 0; i < mr->npages &&
> +	     (total_num_pbes != mr->info.pbl_info.num_pbes); i++) {
> +		u64 buf_addr = mr->pages[i];
> +
> +		pbe->lo = cpu_to_le32((u32)buf_addr);
> +		pbe->hi = cpu_to_le32((u32)upper_32_bits(buf_addr));

Thats a shame... you could have easily set the buf_addr correctly
in qedr_set_page...

I think you could have also set the pbe directly from set_page if you
have access to pbl_table from your mr context
(and if I understand correctly I think you do, mr->info.pbl_table)...