netdev - Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160913154000.GA25878@obsidianresearch.com>
Date:   Tue, 13 Sep 2016 09:40:00 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Ram Amrani <Ram.Amrani@...gic.com>
Cc:     "dledford@...hat.com" <dledford@...hat.com>,
        David Miller <davem@...emloft.net>,
        Yuval Mintz <Yuval.Mintz@...gic.com>,
        Ariel Elior <Ariel.Elior@...gic.com>,
        Michal Kalderon <Michal.Kalderon@...gic.com>,
        Rajesh Borundia <rajesh.borundia@...gic.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

On Tue, Sep 13, 2016 at 08:44:06AM +0000, Ram Amrani wrote:
> Hi Jason,
> I see that "include/uapi/rdma" contains API that is common.

It is intended to contain *all* the uapi.

> The qedr_user.h, that I assume you are referring to, is a qedr specific API.
> For example, we issue the ib_copy_to_udata() on structures defined in the file.
> So per my understanding it is in place.

Anything that is used with copy_to/from_user, ib_copy_to/from_udata,
etc, etc must be in a include/uapi header.

Any constant you might want to copy into your userspace provider must
be in include/uapi.

Avoid copying headers in your user space and use the standard kernel
names to access your driver's uapi.

Jason