netdev - Re: [PATCH net-next 0/7] cxgb4: add support for offloading TC u32 filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160913.121257.1557877495657097138.davem@davemloft.net>
Date:   Tue, 13 Sep 2016 12:12:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, hariprasad@...lsio.com, leedom@...lsio.com,
        nirranjan@...lsio.com, indranil@...lsio.com
Subject: Re: [PATCH net-next 0/7] cxgb4: add support for offloading TC u32
 filters

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Mon, 12 Sep 2016 13:42:33 +0530

> This series of patches add support to offload TC u32 filters onto
> Chelsio NICs.
> 
> Patch 1 moves current common filter code to separate files
> in order to provide a common api for performing packet classification
> and filtering in Chelsio NICs.
> 
> Patch 2 enables filters for normal NIC configuration and implements
> common api for setting and deleting filters.
> 
> Patch 3 provides a debugfs for dumping filter information.
> 
> Patches 4-7 add support for TC u32 offload via ndo_setup_tc.

Like Jiri I'm getting increasingly disappointed how liberally people
toss tons of things into debugfs.

This seems to be the way driver developers throw their hands into the
air when they can't find a quick and easy way to export some piece of
information.

Please work on the long term usability of the kernel and all
networking drivers by finding a bonafide piece of existing
infrastructure by which to export things, or build a new one if
needed.

Thanks.