netdev - RE: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <022b01d20dfc$05864150$1092c3f0$@opengridcomputing.com>
Date:   Tue, 13 Sep 2016 15:18:42 -0500
From:   "Steve Wise" <swise@...ngridcomputing.com>
To:     "'Varun Prakash'" <varun@...lsio.com>, <davem@...emloft.net>
Cc:     <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        <target-devel@...r.kernel.org>, <nab@...ux-iscsi.org>,
        <dledford@...hat.com>, <gerlitz.or@...il.com>,
        <indranil@...lsio.com>
Subject: RE: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

> This patch series removes duplicate code from
> iw_cxgb4 and cxgbit by adding common function
> definitions in libcxgb.
> 
> Please review.
> 
> Thanks
> Varun
> 
> Varun Prakash (11):
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_get_4tuple()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route6()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_is_neg_adv()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_best_mtu()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_compute_wscale()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_tid_release()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_close_con_req()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_req()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_rpl()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_rx_data_ack()
> 
>  drivers/infiniband/hw/cxgb4/Kconfig               |   1 +
>  drivers/infiniband/hw/cxgb4/Makefile              |   1 +
>  drivers/infiniband/hw/cxgb4/cm.c                  | 288
++++++----------------
>  drivers/infiniband/hw/cxgb4/iw_cxgb4.h            |   9 -
>  drivers/net/ethernet/chelsio/libcxgb/Makefile     |   4 +-
>  drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c | 149 +++++++++++
>  drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 160 ++++++++++++
>  drivers/target/iscsi/cxgbit/cxgbit_cm.c           | 234 +++---------------
>  8 files changed, 428 insertions(+), 418 deletions(-)
>  create mode 100644 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c
>  create mode 100644 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h
> 

This series looks good.

Reviewed-by: Steve Wise <swise@...ngridcomputing.com>

Thanks Varun!

Steve