netdev - Re: [PATCH v2 6/6] selftests: move watchdog tests from Documentation/watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57D8628D.3070507@codeaurora.org>
Date:   Tue, 13 Sep 2016 15:33:17 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     Shuah Khan <shuahkh@....samsung.com>, corbet@....net,
        richardcochran@...il.com, wim@...ana.be, linux@...ck-us.net,
        nab@...ux-iscsi.org, maheshkhanwalkar@...il.com, arnd@...db.de,
        ghackmann@...gle.com, ben@...adent.org.uk, thuth@...hat.com,
        christopher.s.hall@...el.com, john.stultz@...aro.org,
        sergei.shtylyov@...entembedded.com, mpe@...erman.id.au,
        jani.nikula@...ux.intel.com
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 6/6] selftests: move watchdog tests from
 Documentation/watchdog

Shuah Khan wrote:
> Remove watchdog-test from Makefile to move the test to selftests.
>
> Add Makefile and .gitignore to for watchdog-test. watchdog-test will

to for?

> not be run as part of selftests suite and will not be included in
> install targets.  It can be built separately for now.
>
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>   Documentation/watchdog/src/.gitignore            |   1 -
>   Documentation/watchdog/src/Makefile              |   2 +-
>   Documentation/watchdog/src/watchdog-test.c       | 105 -----------------------
>   tools/testing/selftests/watchdog/.gitignore      |   1 +
>   tools/testing/selftests/watchdog/Makefile        |   8 ++
>   tools/testing/selftests/watchdog/watchdog-test.c | 105 +++++++++++++++++++++++

Please use -M when calling git-format-patch

>   6 files changed, 115 insertions(+), 107 deletions(-)
>   delete mode 100644 Documentation/watchdog/src/watchdog-test.c
>   create mode 100644 tools/testing/selftests/watchdog/.gitignore
>   create mode 100644 tools/testing/selftests/watchdog/Makefile
>   create mode 100644 tools/testing/selftests/watchdog/watchdog-test.c
>
> diff --git a/Documentation/watchdog/src/.gitignore b/Documentation/watchdog/src/.gitignore
> index ac90997..ff0ebb5 100644
> --- a/Documentation/watchdog/src/.gitignore
> +++ b/Documentation/watchdog/src/.gitignore
> @@ -1,2 +1 @@
>   watchdog-simple
> -watchdog-test

Why not also watchdog-simple?



-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.