netdev - Re: [RFC 02/11] Add RoCE driver framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160913064618.GQ8812@leon.nu>
Date:   Tue, 13 Sep 2016 09:46:19 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Ram Amrani <Ram.Amrani@...gic.com>
Cc:     dledford@...hat.com, davem@...emloft.net, Yuval.Mintz@...gic.com,
        Ariel.Elior@...gic.com, Michal.Kalderon@...gic.com,
        rajesh.borundia@...gic.com, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [RFC 02/11] Add RoCE driver framework

On Mon, Sep 12, 2016 at 07:07:36PM +0300, Ram Amrani wrote:
> Adds a skeletal implementation of the qed* RoCE driver -
> basically the ability to communicate with the qede driver and
> receive notifications from it regarding various init/exit events.
>
> Signed-off-by: Rajesh Borundia <rajesh.borundia@...gic.com>
> Signed-off-by: Ram Amrani <Ram.Amrani@...gic.com>
> ---

<...>

> +
> +#define QEDR_MODULE_VERSION	"8.10.10.0"

I am strongly against module versions. You should rely on official
kernel version.

> +#define QEDR_NODE_DESC "QLogic 579xx RoCE HCA"
> +#define DP_NAME(dev) ((dev)->ibdev.name)

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)