netdev - Re: [RFC V3 PATCH 03/26] net/netpolicy: get device queue irq information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0Uf+guzBrfPUFvMk0RnXbQOJUjkBUp0TeK9HOSb_LU7e8Q@mail.gmail.com>
Date:   Tue, 13 Sep 2016 06:14:13 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     "Liang, Kan" <kan.liang@...el.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>,
        "jmorris@...ei.org" <jmorris@...ei.org>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "kaber@...sh.net" <kaber@...sh.net>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "gorcunov@...nvz.org" <gorcunov@...nvz.org>,
        "john.stultz@...aro.org" <john.stultz@...aro.org>,
        "aduyck@...antis.com" <aduyck@...antis.com>,
        "decot@...glers.com" <decot@...glers.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "tom@...bertland.com" <tom@...bertland.com>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "hannes@...essinduktion.org" <hannes@...essinduktion.org>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "alexei.starovoitov@...il.com" <alexei.starovoitov@...il.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "andi@...stfloor.org" <andi@...stfloor.org>
Subject: Re: [RFC V3 PATCH 03/26] net/netpolicy: get device queue irq information

On Tue, Sep 13, 2016 at 5:23 AM, Liang, Kan <kan.liang@...el.com> wrote:
>>
>> Hello.
>>
>> On 09/12/2016 05:55 PM, kan.liang@...el.com wrote:
>>
>> > From: Kan Liang <kan.liang@...el.com>
>> >
>> > Net policy needs to know device information. Currently, it's enough to
>> > only get irq information of rx and tx queues.
>> >
>> > This patch introduces ndo ops to do so, not ethtool ops.
>> > Because there are already several ways to get irq information in
>> > userspace. It's not necessory to extend the ethtool.
>>
>>     Necessary.
>
> OK. I will extend the ethtool in next version.
>
> Thanks,
> Kan

Kan, I don't think Sergei was saying you have to extend the ethtool.
Your spelling of necessary was incorrect in your patch description.

Sergei, please feel free to tell me I am wrong if my assumption on
that is incorrect.

- Alex