netdev - [PATCH stable] tipc: apply skb linearization commit to stable 4.4.x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1473866917-10520-1-git-send-email-jon.maloy@ericsson.com>
Date:   Wed, 14 Sep 2016 11:28:37 -0400
From:   Jon Maloy <jon.maloy@...csson.com>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        parthasarathy.bhuvaragan@...csson.com, richard.alpe@...csson.com,
        ying.xue@...driver.com, maloy@...jonn.com,
        tipc-discussion@...ts.sourceforge.net,
        Jon Maloy <jon.maloy@...csson.com>
Subject: [PATCH stable] tipc: apply skb linearization commit to stable 4.4.x

commit c7cad0d6f70cd upstream
(“tipc: move linearization of buffers to generic code”)

was applied to net-next in November 2015, and is present in kernel
versions from 4.5.x onwards.

We later discovered that this commit also fixes a serious bug, since
even L2 buffers may arrive non-linearized. Hence, in 4.4.x kernels we
often see debug printouts like this:

[880.688856] Dropping name table update (0) of {1651649891, 1819082752, 0} from <1.1.1> key=402710022
[880.688862] Dropping name table update (0) of {4029808599, 2711729614, 1639218685} from <1.1.1> key=18102394
[880.688865] Dropping name table update (0) of {134218495, 4278191616, 100669184} from <1.1.1> key=0

Those are symptoms of the binding table having received "corrupt" 
publications read linearly from non-linear buffers. The above listed
commit solves this problem, and should be applied even to 4.4 kernels.

2.7.4