netdev - Re: [PATCH V2 3/3] net-next: dsa: add new driver for qca8xxx family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12cdce62-b5a4-c423-2532-d86f159d3be6@phrozen.org>
Date:   Wed, 14 Sep 2016 17:47:53 +0200
From:   John Crispin <john@...ozen.org>
To:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        qsdk-review@....qualcomm.com
Subject: Re: [PATCH V2 3/3] net-next: dsa: add new driver for qca8xxx family



On 14/09/2016 12:39, John Crispin wrote:
> +static void
> +qca8k_fdb_add(struct dsa_switch *ds, int port,
> +	      const struct switchdev_obj_port_fdb *fdb,
> +	      struct switchdev_trans *trans)
> +{
> +	struct qca8k_priv *priv = qca8k_to_priv(ds);
> +	u16 port_mask = BIT(port);
> +	u16 vid = fdb->vid;
> +
> +	if (!vid)
> +		vid = 1;
> +
> +	qca8k_fdb_write(priv, vid, port_mask, fdb->addr,
> +			QCA8K_ATU_STATUS_STATIC);
> +
> +	qca8k_fdb_access(priv, QCA8K_FDB_LOAD, -1);
> +}
> +
> +static int
> +qca8k_fdb_del(struct dsa_switch *ds, int port,
> +	      const struct switchdev_obj_port_fdb *fdb)
> +{
> +	struct qca8k_priv *priv = qca8k_to_priv(ds);
> +	u16 port_mask = BIT(port);
> +
> +	qca8k_fdb_write(priv, fdb->vid, port_mask, fdb->addr, 0);
> +
> +	return qca8k_fdb_access(priv, QCA8K_FDB_PURGE, -1);
> +}
> +

while adding MDB support i noticed that

1) the code above is still not properly locked
2) i can unify the FDB and MDB code

i will send a V3 with those 2 changes tomorrow.

	John