netdev - Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160914171737.GH16014@obsidianresearch.com>
Date:   Wed, 14 Sep 2016 11:17:37 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     "Amrani, Ram" <Ram.Amrani@...ium.com>
Cc:     "dledford@...hat.com" <dledford@...hat.com>,
        David Miller <davem@...emloft.net>,
        Yuval Mintz <Yuval.Mintz@...gic.com>,
        Ariel Elior <Ariel.Elior@...gic.com>,
        Michal Kalderon <Michal.Kalderon@...gic.com>,
        Rajesh Borundia <rajesh.borundia@...gic.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

On Wed, Sep 14, 2016 at 02:44:47PM +0000, Amrani, Ram wrote:
> > Anything that is used with copy_to/from_user, ib_copy_to/from_udata, 
> > etc, etc must be in a include/uapi header.
> > 
> > Any constant you might want to copy into your userspace provider must 
> > be in include/uapi.
> > 
> I understand you mean something like
> https://www.spinics.net/lists/linux-rdma/msg40414.html ([RFC
> rdma-next 0/3] Move mlx5 vendor specific to UAPI directory)

Yes.

> > Avoid copying headers in your user space and use the standard kernel 
> > names to access your driver's uapi.

> So the user library should be able to compile against these headers
> in their location and not hold identical copies.

Yes, but you will need identical copies for supporting old distros.

> What do you mean by "standard kernel names"?

By that I mean 'identical copies' do not copy the file and then
randomly change it giving things different names or putting different
content in structs.

You will want to submit your user provider to rdma-plumbing to get it
into the distros, we are planning to set it as the vehicle for code
targeting 4.9

Jason