netdev - RE: [PATCH net-next 3/5] liquidio CN23XX: Mailbox support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM3PR07MB2138932DA3ADB67A07856E7381F10@DM3PR07MB2138.namprd07.prod.outlook.com>
Date:   Wed, 14 Sep 2016 01:25:10 +0000
From:   "Vatsavayi, Raghu" <Raghu.Vatsavayi@...ium.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Chickles, Derek" <Derek.Chickles@...ium.com>,
        "Burla, Satananda" <Satananda.Burla@...ium.com>,
        "Manlunas, Felix" <Felix.Manlunas@...ium.com>
Subject: RE: [PATCH net-next 3/5] liquidio CN23XX: Mailbox support

Sure Dave, Will submit new patches with these changes.
Thanks
Raghu.

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Saturday, September 10, 2016 9:42 PM
> To: Vatsavayi, Raghu
> Cc: netdev@...r.kernel.org; Chickles, Derek; Burla, Satananda; Manlunas,
> Felix; Vatsavayi, Raghu
> Subject: Re: [PATCH net-next 3/5] liquidio CN23XX: Mailbox support
> 
> From: Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>
> Date: Fri, 9 Sep 2016 13:08:25 -0700
> 
> > +int octeon_mbox_read(struct octeon_mbox *mbox) {
> > +	int ret = 0;
> > +	union octeon_mbox_message msg;
> > +
> 
> Please always order local variable declarations from longest to shortest line.
> 
> Please audit your entire submission for this problem.