netdev - Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160915202219.GB1867@uranus.lan>
Date:   Thu, 15 Sep 2016 23:22:19 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     David Ahern <dsa@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        David Miller <davem@...emloft.net>, eric.dumazet@...il.com,
        kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
        kaber@...sh.net, avagin@...nvz.org, stephen@...workplumber.org
Subject: Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

On Thu, Sep 15, 2016 at 01:53:13PM -0600, David Ahern wrote:
> On 9/13/16 11:19 AM, Cyrill Gorcunov wrote:
> > In criu we are actively using diag interface to collect sockets
> > present in the system when dumping applications. And while for
> > unix, tcp, udp[lite], packet, netlink it works as expected,
> > the raw sockets do not have. Thus add it.
> > 
> > v2:
> >  - add missing sock_put calls in raw_diag_dump_one (by eric.dumazet@)
> >  - implement @destroy for diag requests (by dsa@)
> > 
> > v3:
> >  - add export of raw_abort for IPv6 (by dsa@)
> >  - pass net-admin flag into inet_sk_diag_fill due to
> >    changes in net-next branch (by dsa@)
> > 
> > CC: David S. Miller <davem@...emloft.net>
> > CC: Eric Dumazet <eric.dumazet@...il.com>
> > CC: David Ahern <dsa@...ulusnetworks.com>
> > CC: Alexey Kuznetsov <kuznet@....inr.ac.ru>
> > CC: James Morris <jmorris@...ei.org>
> > CC: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> > CC: Patrick McHardy <kaber@...sh.net>
> > CC: Andrey Vagin <avagin@...nvz.org>
> > CC: Stephen Hemminger <stephen@...workplumber.org>
> > Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> > ---
> 
> ss -K is not working. Socket lookup fails to find a match due to a protocol mismatch.
> 
> haven't had time to track down why there is a mismatch since the kill uses the socket returned
> from the dump. Won't have time to come back to this until early next week.

Have you ran iproute2 patched? I just ran ss -K and all sockets get closed
(including raw ones), which actually kicked me off the testing machine sshd :/

	Cyrill