netdev - Re: [PATCH v3 net 1/1] net sched actions: fix GETing actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160915.193302.677247650007637133.davem@davemloft.net>
Date:   Thu, 15 Sep 2016 19:33:02 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jhs@...atatu.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com
Subject: Re: [PATCH v3 net 1/1] net sched actions: fix GETing actions

From: Jamal Hadi Salim <jhs@...atatu.com>
Date: Mon, 12 Sep 2016 19:07:38 -0400

> From: Jamal Hadi Salim <jhs@...atatu.com>
> 
> With the batch changes that translated transient actions into
> a temporary list lost in the translation was the fact that
> tcf_action_destroy() will eventually delete the action from
> the permanent location if the refcount is zero.
> 
> Example of what broke:
> ...add a gact action to drop
> sudo $TC actions add action drop index 10
> ...now retrieve it, looks good
> sudo $TC actions get action gact index 10
> ...retrieve it again and find it is gone!
> sudo $TC actions get action gact index 10
> 
> Fixes:
> commit 22dc13c837c3 ("net_sched: convert tcf_exts from list to pointer array"),
> commit 824a7e8863b3 ("net_sched: remove an unnecessary list_del()")
> commit f07fed82ad79 ("net_sched: remove the leftover cleanup_a()")
> 
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>

Please incorporate Sergei's feedback and resubmit, thanks Jamal.