netdev - Re: [PATCH net-next 07/14] tcp: export data delivery rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201609171104.7NaqQo41%fengguang.wu@intel.com>
Date:   Sat, 17 Sep 2016 11:56:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        netdev@...r.kernel.org, Yuchung Cheng <ycheng@...gle.com>,
        Van Jacobson <vanj@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Nandita Dukkipati <nanditad@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH net-next 07/14] tcp: export data delivery rate

Hi Yuchung,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323
config: arm-nhk8815_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

   In file included from arch/arm/include/asm/div64.h:126:0,
                    from include/linux/kernel.h:142,
                    from include/linux/crypto.h:21,
                    from include/crypto/hash.h:16,
                    from net/ipv4/tcp.c:250:
   net/ipv4/tcp.c: In function 'tcp_get_info':
   include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast
     (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
                               ^
>> net/ipv4/tcp.c:2794:3: note: in expansion of macro 'do_div'
      do_div(rate, intv);
      ^~~~~~
   In file included from arch/arm/include/asm/atomic.h:14:0,
                    from include/linux/atomic.h:4,
                    from include/linux/crypto.h:20,
                    from include/crypto/hash.h:16,
                    from net/ipv4/tcp.c:250:
   include/asm-generic/div64.h:220:25: warning: right shift count >= width of type [-Wshift-count-overflow]
     } else if (likely(((n) >> 32) == 0)) {  \
                            ^
   include/linux/compiler.h:167:40: note: in definition of macro 'likely'
    # define likely(x) __builtin_expect(!!(x), 1)
                                           ^
>> net/ipv4/tcp.c:2794:3: note: in expansion of macro 'do_div'
      do_div(rate, intv);
      ^~~~~~
   In file included from arch/arm/include/asm/div64.h:126:0,
                    from include/linux/kernel.h:142,
                    from include/linux/crypto.h:21,
                    from include/crypto/hash.h:16,
                    from net/ipv4/tcp.c:250:
>> include/asm-generic/div64.h:224:22: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
      __rem = __div64_32(&(n), __base); \
                         ^
>> net/ipv4/tcp.c:2794:3: note: in expansion of macro 'do_div'
      do_div(rate, intv);
      ^~~~~~
   In file included from include/linux/kernel.h:142:0,
                    from include/linux/crypto.h:21,
                    from include/crypto/hash.h:16,
                    from net/ipv4/tcp.c:250:
   arch/arm/include/asm/div64.h:32:24: note: expected 'uint64_t * {aka long long unsigned int *}' but argument is of type 'u32 * {aka unsigned int *}'
    static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
                           ^~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/do_div +2794 net/ipv4/tcp.c

  2778		} while (u64_stats_fetch_retry_irq(&tp->syncp, start));
  2779		info->tcpi_segs_out = tp->segs_out;
  2780		info->tcpi_segs_in = tp->segs_in;
  2781	
  2782		notsent_bytes = READ_ONCE(tp->write_seq) - READ_ONCE(tp->snd_nxt);
  2783		info->tcpi_notsent_bytes = max(0, notsent_bytes);
  2784	
  2785		info->tcpi_min_rtt = tcp_min_rtt(tp);
  2786		info->tcpi_data_segs_in = tp->data_segs_in;
  2787		info->tcpi_data_segs_out = tp->data_segs_out;
  2788	
  2789		info->tcpi_delivery_rate_app_limited = tp->rate_app_limited ? 1 : 0;
  2790		rate = READ_ONCE(tp->rate_delivered);
  2791		intv = READ_ONCE(tp->rate_interval_us);
  2792		if (rate && intv) {
  2793			rate = rate * tp->mss_cache * USEC_PER_SEC;
> 2794			do_div(rate, intv);
  2795			put_unaligned(rate, &info->tcpi_delivery_rate);
  2796		}
  2797	}
  2798	EXPORT_SYMBOL_GPL(tcp_get_info);
  2799	
  2800	static int do_tcp_getsockopt(struct sock *sk, int level,
  2801			int optname, char __user *optval, int __user *optlen)
  2802	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (14948 bytes)