netdev - Re: [PATCH net-next v2 2/5] cxgb4: add common api support for configuring filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Sep 2016 20:18:04 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, hariprasad@...lsio.com, leedom@...lsio.com,
        nirranjan@...lsio.com, indranil@...lsio.com
Subject: Re: [PATCH net-next v2 2/5] cxgb4: add common api support for
 configuring filters

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Tue, 13 Sep 2016 17:12:26 +0530

> +/* Fill up default masks for set match fields. */
> +static void fill_default_mask(struct ch_filter_specification *fs)
> +{
> +	unsigned int i;
> +	unsigned int lip = 0, lip_mask = 0;
> +	unsigned int fip = 0, fip_mask = 0;

Always order local variable declarations from longest to shortest
line.

Please audit your entire submission for this issue.

Thanks.