netdev - Re: [PATCH v2 2/2] openvswitch: use percpu flow stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_Dus4NmhGEaN=i5pnvKDY0aTvgMFL19K7gF9pdsLAp4xw@mail.gmail.com>
Date:   Sat, 17 Sep 2016 19:07:30 -0700
From:   pravin shelar <pshelar@....org>
To:     Thadeu Lima de Souza Cascardo <cascardo@...hat.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        ovs dev <dev@...nvswitch.org>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v2 2/2] openvswitch: use percpu flow stats

On Thu, Sep 15, 2016 at 3:11 PM, Thadeu Lima de Souza Cascardo
<cascardo@...hat.com> wrote:
> Instead of using flow stats per NUMA node, use it per CPU. When using
> megaflows, the stats lock can be a bottleneck in scalability.
>
> On a E5-2690 12-core system, usual throughput went from ~4Mpps to
> ~15Mpps when forwarding between two 40GbE ports with a single flow
> configured on the datapath.
>
> This has been tested on a system with possible CPUs 0-7,16-23. After
> module removal, there were no corruption on the slab cache.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...hat.com>
> Cc: pravin shelar <pshelar@....org>

Looks good.

Acked-by: Pravin B Shelar <pshelar@....org>