netdev - Re: [PATCH] net: mvneta: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8cba4a0e-cbf6-ca67-a117-4c558d2c36f1@cogentembedded.com>
Date:   Sun, 18 Sep 2016 15:05:12 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>,
        thomas.petazzoni@...e-electrons.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, xie.baoyou@....com.cn
Subject: Re: [PATCH] net: mvneta: mark symbols static where possible

Hello.

On 9/18/2016 12:20 PM, Baoyou Xie wrote:

> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/marvell/mvneta.c:639:27: warning: no previous prototype for 'mvneta_get_stats64' [-Wmissing-prototypes]
> drivers/net/ethernet/marvell/mvneta.c:3529:5: warning: no previous prototype for 'mvneta_ethtool_set_link_ksettings' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/net/ethernet/marvell/mvneta.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 32f0cc4..03be592 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -636,8 +636,9 @@ static void mvneta_mib_counters_clear(struct mvneta_port *pp)
>  }
>
>  /* Get System Network Statistics */
> -struct rtnl_link_stats64 *mvneta_get_stats64(struct net_device *dev,
> -					     struct rtnl_link_stats64 *stats)
> +static struct
> +rtnl_link_stats64 *mvneta_get_stats64(struct net_device *dev,

    I'd break the line after * heren not where you did it. This way the 
function type would remain all in one line.

> +				      struct rtnl_link_stats64 *stats)
>  {
>  	struct mvneta_port *pp = netdev_priv(dev);
>  	unsigned int start;
[...]

MBR, Sergei