netdev - Re: [PATCH net-next] pkt_sched: fq: use proper locking in fq_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160918.221706.1619375593697818367.davem@davemloft.net>
Date:   Sun, 18 Sep 2016 22:17:06 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] pkt_sched: fq: use proper locking in
 fq_dump_stats()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 15 Sep 2016 16:20:01 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> When fq is used on 32bit kernels, we need to lock the qdisc before
> copying 64bit fields.
> 
> Otherwise "tc -s qdisc ..." might report bogus values.
> 
> Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.