netdev - Re: [PATCH v2 2/2] net: skbuff: Coding: Use eth_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1474306670.22679.93.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Mon, 19 Sep 2016 10:37:50 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Shmulik Ladkani <shmulik.ladkani@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/2] net: skbuff: Coding: Use eth_type_vlan() instead
 of open coding it

On Mon, 2016-09-19 at 19:23 +0300, Shmulik Ladkani wrote:
> On Mon, 19 Sep 2016 09:20:55 -0700 Eric Dumazet <eric.dumazet@...il.com> wrote:
> > On Mon, 2016-09-19 at 18:53 +0300, Shmulik Ladkani wrote:
> > > Fix 'skb_vlan_pop' to use eth_type_vlan instead of directly comparing
> > > skb->protocol to ETH_P_8021Q or ETH_P_8021AD.
> > > 
> > > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@...il.com>
> > > ---  
> > 
> > You forgot to explicitly state this was targeting net-next tree.
> 
> Thanks, was an oversight.
> Requires resubmission?

I do not think so.

I only reminded it because it seems many netdev submissions
are forgetting this, and it does not help David Miller job.

Thanks