netdev - Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJXLkmLG8rjWA3rsC88-E1Q-hQRbXc2pgtuDK6eOoiz7g@mail.gmail.com>
Date:   Mon, 19 Sep 2016 14:23:14 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Rick Jones <rick.jones2@....com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Neal Cardwell <ncardwell@...gle.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, Van Jacobson <vanj@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Nandita Dukkipati <nanditad@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

On Mon, Sep 19, 2016 at 2:17 PM, Rick Jones <rick.jones2@....com> wrote:

>
> Are there better than epsilon odds of someone perhaps wanting to poke those
> values as it gets exposure beyond Google?
>

This does not matter.

A change would require patching net/ipv4/tcp_bbr.c , and the 'const'
attribute being there or not does not prevent the change.

I was simply asking to Stephen if the compiler would actually emit a
very different code, worth doing a last minute change.

The main BBR costs are divides and some multiplies , and they are
using per socket fields.