netdev - RE: [PATCH net-next 09/10] bnxt_en: Support for "ethtool -r" command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL2PR07MB23060AC65DF1DD370DD086DF8DF40@BL2PR07MB2306.namprd07.prod.outlook.com>
Date:   Mon, 19 Sep 2016 08:27:38 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Michael Chan <michael.chan@...adcom.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 09/10] bnxt_en: Support for "ethtool -r" command

> Restart autoneg if autoneg is enabled.

> +	if (!(link_info->autoneg & BNXT_AUTONEG_SPEED))
> +		return -EINVAL;

Looks like a lot of the of implementations of this ethtool
are unconditionally doing the reset.
Perhaps the right thing to do is check for autoneg availability
at the ethtool core itself?

[Not an objection to this patch in any way as there are tens
of implementations doing the same; Simply noting this]