netdev - RE: [RFC 03/11] Add support for RoCE HW init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR07MB220779C6959D793C5D1B7223F8F40@SN1PR07MB2207.namprd07.prod.outlook.com>
Date:   Mon, 19 Sep 2016 08:45:50 +0000
From:   "Amrani, Ram" <Ram.Amrani@...ium.com>
To:     Sagi Grimberg <sagi@...mberg.me>
CC:     "Yuval.Mintz@...gic.com" <Yuval.Mintz@...gic.com>,
        "Ariel.Elior@...gic.com" <Ariel.Elior@...gic.com>,
        "Michal.Kalderon@...gic.com" <Michal.Kalderon@...gic.com>,
        "rajesh.borundia@...gic.com" <rajesh.borundia@...gic.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [RFC 03/11] Add support for RoCE HW init

> > > +	dev->max_sge = min_t(u32, RDMA_MAX_SGE_PER_SQ_WQE,
> > > +			     RDMA_MAX_SGE_PER_RQ_WQE);
> >
> > Our kernel target mode consumers sort of rely on max_sge_rd, you need
> > to make sure to set it too.
> Good catch. Thanks!

Actually, as I come to code this, I just realized that max_sge_rd is already set in the  query verb itself:

+int qedr_query_device(struct ib_device *ibdev,
+                     struct ib_device_attr *attr, struct ib_udata *udata)
+{

<snip>

+       attr->max_sge = qattr->max_sge;
+       attr->max_sge_rd = qattr->max_sge;