netdev - Re: [net-next PATCH V2] mlx4: add missed recycle opportunity for XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160920.045843.1654100968407894492.davem@davemloft.net>
Date:   Tue, 20 Sep 2016 04:58:43 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     brouer@...hat.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com,
        eric.dumazet@...il.com, tom@...bertland.com, bblanco@...mgrid.com,
        rana.shahot@...il.com
Subject: Re: [net-next PATCH V2] mlx4: add missed recycle opportunity for
 XDP_TX on TX failure

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Mon, 19 Sep 2016 17:46:38 +0200

> Correct drop handling for XDP_TX on TX failure, were recently added in
> commit 95357907ae73 ("mlx4: fix XDP_TX is acting like XDP_PASS on TX
> ring full").
> 
> The change missed an opportunity for recycling the RX page, instead of
> going through the page allocator, like the regular XDP_DROP action does.
> This patch cease the opportunity, by going through the XDP_DROP case.
> 
> Fixes: 95357907ae73 ("mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Reviewed-by: Tariq Toukan <tariqt@...lanox.com>

Applied, thanks.