netdev - Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160920093659.GA20975@gondor.apana.org.au>
Date:   Tue, 20 Sep 2016 17:36:59 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Tom Herbert <tom@...bertland.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, tgraf@...g.ch,
        roopa@...ulusnetworks.com, kernel-team@...com
Subject: Re: [PATCH net-next 5/7] rhashtable: abstract out function to get
 hash

Tom Herbert <tom@...bertland.com> wrote:
> Split out most of rht_key_hashfn which is calculating the hash into
> its own function. This way the hash function can be called separately to
> get the hash value.
> 
> Acked-by: Thomas Graf <tgraf@...g.ch>
> Signed-off-by: Tom Herbert <tom@...bertland.com>

I don't get this one.  You're just using jhash, right? Why not
call jhash directly instead of rht_get_key_hashfn?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt