netdev - Re: [PATCH 1/1] ixgbe: replace defined with IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=hENd2MO-3AuFZQz0i4sPSf5puDyrqgDw8Xgh=LnOXPizVrQ@mail.gmail.com>
Date:   Tue, 20 Sep 2016 21:09:47 +0800
From:   zhuyj <zyjzyj2000@...il.com>
To:     "Tantilov, Emil S" <emil.s.tantilov@...el.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "e1000-devel@...ts.sourceforge.net" 
        <e1000-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 1/1] ixgbe: replace defined with IS_ENABLED

how about this patch "ixgbe: remove the useless header file ixgbe_type.h"?

On Tue, Sep 20, 2016 at 1:00 AM, Tantilov, Emil S
<emil.s.tantilov@...el.com> wrote:
>>-----Original Message-----
>>From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On
>>Behalf Of zyjzyj2000@...il.com
>>Sent: Wednesday, September 14, 2016 8:27 AM
>>To: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; Kirsher,
>>Jeffrey T <jeffrey.t.kirsher@...el.com>; zyjzyj2000@...il.com; e1000-
>>devel@...ts.sourceforge.net
>>Subject: [PATCH 1/1] ixgbe: replace defined with IS_ENABLED
>>
>>From: Zhu Yanjun <zyjzyj2000@...il.com>
>>
>>Replace defined macro with IS_ENABLED in ixgbe.h file
>>
>>Signed-off-by: Zhu Yanjun <zyjzyj2000@...il.com>
>>---
>> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>index 9475ff9..f8bc1d0 100644
>>--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>@@ -45,7 +45,7 @@
>> #include "ixgbe_type.h"
>> #include "ixgbe_common.h"
>> #include "ixgbe_dcb.h"
>>-#if defined(CONFIG_FCOE) || defined(CONFIG_FCOE_MODULE)
>>+#if IS_ENABLED(CONFIG_FCOE)
>> #define IXGBE_FCOE
>> #include "ixgbe_fcoe.h"
>> #endif /* CONFIG_FCOE or CONFIG_FCOE_MODULE */
>>--
>>2.7.4
>
> Already taken care of by the following patch:
> http://patchwork.ozlabs.org/patch/668894/
>
> Thanks,
> Emil
>