netdev - Re: [PATCH] netfilter: xt_socket: fix transparent match for IPv6 request sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1474383935.23058.20.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 20 Sep 2016 08:05:35 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     KOVACS Krisztian <hidden@...abit.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        netfilter-devel@...r.kernel.org,
        Alex Badics <alex.badics@...abit.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] netfilter: xt_socket: fix transparent match for IPv6
 request sockets

On Tue, 2016-09-20 at 08:01 -0700, Eric Dumazet wrote:

> 
> Something like :
> 
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index 3ebf45b38bc3..0fccfd6cc258 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -6264,6 +6264,7 @@ int tcp_conn_request(struct request_sock_ops *rsk_ops,
>  	/* Note: tcp_v6_init_req() might override ir_iif for link locals */
>  	inet_rsk(req)->ir_iif = inet_request_bound_dev_if(sk, skb);
>  
> +	ireq->no_srccheck = inet_sk(sk)->transparent;

Since there is no @ireq there, simply use :

	inet_rsk(req)->no_srccheck = inet_sk(sk)->transparent;


>  	af_ops->init_req(req, sk, skb);
>