netdev - Re: [PATCH net-next 8/8] net: qualcomm: add QCA7000 UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2EE064FD-FCC1-4559-819D-471BD000F5AF@holtmann.org>
Date:   Tue, 20 Sep 2016 17:32:36 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH net-next 8/8] net: qualcomm: add QCA7000 UART driver

Hi Stefan,

> This patch adds the Ethernet over UART driver for the
> Qualcomm QCA7000 HomePlug GreenPHY.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>
> ---
> drivers/net/ethernet/qualcomm/Kconfig      |  12 +
> drivers/net/ethernet/qualcomm/Makefile     |   2 +
> drivers/net/ethernet/qualcomm/qca_common.h |   6 +
> drivers/net/ethernet/qualcomm/qca_uart.c   | 447 +++++++++++++++++++++++++++++
> include/uapi/linux/tty.h                   |   1 +
> 5 files changed, 468 insertions(+)
> create mode 100644 drivers/net/ethernet/qualcomm/qca_uart.c
> 
> diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
> index 0d33728..0ede46e 100644
> --- a/drivers/net/ethernet/qualcomm/Kconfig
> +++ b/drivers/net/ethernet/qualcomm/Kconfig
> @@ -30,6 +30,18 @@ config QCA7000_SPI
> 	  To compile this driver as a module, choose M here. The module
> 	  will be called qcaspi.
> 
> +config QCA7000_UART
> +	tristate "Qualcomm Atheros QCA7000 UART support"
> +	select QCA7000
> +	depends on TTY
> +	---help---
> +	  This UART protocol driver supports the Qualcomm Atheros QCA7000.
> +	  The driver implements the tty line discipline N_QCA7K and supports
> +	  only one netdevice.
> +
> +	  To compile this driver as a module, choose M here. The module
> +	  will be called qcauart.
> +

this seems to be another candidate for having a proper UART or serial bus. Instead of adding one line discipline after another, I think we need to get quickly to having an enumerable bus here.

Regards

Marcel