netdev - Re: [PATCH] net: hns: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160919.215633.1223352245725461474.davem@davemloft.net>
Date:   Mon, 19 Sep 2016 21:56:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     baoyou.xie@...aro.org
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        yankejian@...wei.com, huangdaode@...ilicon.com,
        lisheng011@...wei.com, fabf@...net.be, xieqianqian@...wei.com,
        lipeng321@...wei.com, weiyongjun1@...wei.com, liguozhu@...wei.com,
        arnd@...db.de, andrew@...n.ch, chenny.xu@...wei.com,
        xypron.glpk@....de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, xie.baoyou@....com.cn
Subject: Re: [PATCH] net: hns: mark symbols static where possible

From: Baoyou Xie <baoyou.xie@...aro.org>
Date: Sun, 18 Sep 2016 17:07:25 +0800

> We get a few warnings when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hisi_femac.c:960:5: warning: no previous prototype for 'hisi_femac_drv_resume' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous prototype for 'hns_ae_get_handle' [-Wmissing-prototypes]
> ....
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Does not apply cleanly to net-next, please respin.