netdev - Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160920175803.GE3291@pox.localdomain>
Date:   Tue, 20 Sep 2016 19:58:03 +0200
From:   Thomas Graf <tgraf@...g.ch>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Tom Herbert <tom@...bertland.com>, davem@...emloft.net,
        netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        kernel-team@...com
Subject: Re: [PATCH net-next 5/7] rhashtable: abstract out function to get
 hash

On 09/20/16 at 05:36pm, Herbert Xu wrote:
> Tom Herbert <tom@...bertland.com> wrote:
> > Split out most of rht_key_hashfn which is calculating the hash into
> > its own function. This way the hash function can be called separately to
> > get the hash value.
> > 
> > Acked-by: Thomas Graf <tgraf@...g.ch>
> > Signed-off-by: Tom Herbert <tom@...bertland.com>
> 
> I don't get this one.  You're just using jhash, right? Why not
> call jhash directly instead of rht_get_key_hashfn?

FYI, there is a v2 of this series, just so you don't have to do the
work twice.

I understand this particular patch as an effort not to duplicate
hash function selection such as jhash vs jhash2 based on key_len.