netdev - Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57E1C4CE.7000104@iogearbox.net>
Date:   Wed, 21 Sep 2016 01:22:54 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Thomas Graf <tgraf@...g.ch>, Tom Herbert <tom@...bertland.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Kernel Team <kernel-team@...com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Brenden Blanco <bblanco@...mgrid.com>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On 09/21/2016 01:09 AM, Thomas Graf wrote:
> On 09/20/16 at 03:49pm, Tom Herbert wrote:
>> On Tue, Sep 20, 2016 at 3:44 PM, Thomas Graf <tgraf@...g.ch> wrote:
>>> On 09/20/16 at 03:00pm, Tom Herbert wrote:
>>>> +static inline int __xdp_hook_run(struct list_head *list_head,
>>>> +                              struct xdp_buff *xdp)
>>>> +{
>>>> +     struct xdp_hook_ops *elem;
>>>> +     int ret = XDP_PASS;
>>>> +
>>>> +     list_for_each_entry(elem, list_head, list) {
>>>> +             ret = elem->hook(elem->priv, xdp);
>>>> +             if (ret != XDP_PASS)
>>>> +                     break;
>>>> +     }
>>>
>>> Walking over a linear list? Really? :-) I thought this was supposed
>>> to be fast, no compromises made.
>>
>> Can you suggest an alternative?
>
> Single BPF program that encodes whatever logic is required. This is
> what BPF is for. If it absolutely has to run two programs in sequence
> then it can still do that even though I really don't see much of a
> point of doing that in a high performance environment.

Agreed, if there's one thing I would change in cls_bpf, then it's getting
rid of the (uapi unfortunately) list of classifiers and just make it a
single one, because that's all that is needed, and chaining/pipelining
can be done via tail calls for example. This whole list + callback likely
also makes things slower. Why not let more drivers come first to support
the current xdp model we have, and then we can move common parts to the
driver-independent core code?

> I'm not even sure yet I understand full purpose of this yet ;-)