netdev - Re: [PATCH net-next V2] net/vxlan: Avoid unaligned access in vxlan_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4617aca3-8d44-e99a-cc5a-1088b30ae327@stressinduktion.org>
Date:   Wed, 21 Sep 2016 12:10:55 +0200
From:   Hannes Frederic Sowa <hannes@...essinduktion.org>
To:     Sowmini Varadhan <sowmini.varadhan@...cle.com>,
        netdev@...r.kernel.org
Cc:     jbenc@...hat.com, davem@...emloft.net
Subject: Re: [PATCH net-next V2] net/vxlan: Avoid unaligned access in
 vxlan_build_skb()

On 20.09.2016 20:57, Sowmini Varadhan wrote:
> The vxlan header may not be aligned to 4 bytes in
> vxlan_build_skb (e.g., for MLD packets). This patch
> avoids unaligned access traps from vxlan_build_skb
> (in platforms like sparc) by making struct vxlanhdr __packed.
> 
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>

Performance wise this should only affect code generation for archs where
it matters anyway.

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Thanks,
Hannes