netdev - Re: [PATCH v2 0/2] make POSIX timers optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2016 12:20:30 +0200
From:   Jiri Benc <jbenc@...hat.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Nicolas Pitre <nicolas.pitre@...aro.org>,
        Richard Cochran <richardcochran@...il.com>,
        John Stultz <john.stultz@...aro.org>,
        Josh Triplett <josh@...htriplett.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, 20 Sep 2016 23:09:52 +0200 (CEST), Thomas Gleixner wrote:
> Now if you want to distangle PTP from a driver then you split it at the
> driver level and not at the PTP level:
> 
>       	  DRIVER_X
> 	  tristate "Driver X"
> 
> 	  DRIVER_X_PTP
> 	  bool "Enable PTP support"
> 	  default y if !MAKE_IT_TINY
> 	  depends on DRIVER_X
> 	  select PTP

Ouch. So, after the hassle to remove the VXLAN and GENEVE configs from
tons of drivers, we'll add another one instead? That's just silly. If
we did this for every thing we support in NICs, we would end up with
something completely unmanageable.

PTP should be really configured by a single switch.

Btw., your suggestion does not work, select is not recursive.

> We have already drivers following that scheme. That way you make the PTP
> support in the driver conditional on DRIVER_X_PTP and have no hassle with
> modules and dependencies.

We've recently got rid of some of those, thankfully. Caused more harm
than good.

 Jiri