netdev - Re: [PATCH next 1/2] sctp: rename WORD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6b400c34-88a1-dd11-aa0c-0812a8736f24@gmail.com>
Date:   Wed, 21 Sep 2016 08:04:05 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>, vyasevich@...il.com,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH next 1/2] sctp: rename WORD_TRUNC/ROUND macros

Em 21-09-2016 07:18, David Laight escreveu:
> From: Marcelo Ricardo Leitner
>> Sent: 20 September 2016 21:24
>> To something more meaningful these days, specially because this is
>> working on packet headers or lengths and which are not tied to any CPU
>> arch but to the protocol itself.
>>
>> So, WORD_TRUNC becomes SCTP_TRUNC4 and WORD_ROUND becomes SCTP_ALIGN4.
> ...
>>  /* Round an int up to the next multiple of 4.  */
>> -#define WORD_ROUND(s) (((s)+3)&~3)
>> +#define SCTP_ALIGN4(s) (((s)+3)&~3)
>
> SCTP_PAD4() might be a better name.

Right. Will post a v3 with it. Thanks

   Marcelo