netdev - Re: [PATCH iproute2] ipmonitor: fix ip monitor can't work when NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160921163340.5af57e7c@xeon-e3>
Date:   Wed, 21 Sep 2016 16:33:40 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Liping Zhang <zlpnobody@...il.com>
Cc:     netdev@...r.kernel.org, nicolas.dichtel@...nd.com,
        Liping Zhang <liping.zhang@...eadtrum.com>
Subject: Re: [PATCH iproute2] ipmonitor: fix ip monitor can't work when
 NET_NS is not enabled

On Tue, 20 Sep 2016 02:09:02 -0700
Liping Zhang <zlpnobody@...il.com> wrote:

> From: Liping Zhang <liping.zhang@...eadtrum.com>
> 
> In ip monitor, netns_map_init will check getnsid is supported or not.
> But when /proc/self/ns/net does not exist, we just print out error
> messages and exit. So user cannot use ip monitor anymore when
> CONFIG_NET_NS is disabled:
>   # ip monitor
>   open("/proc/self/ns/net"): No such file or directory
> 
> If open "/proc/self/ns/net" failed, set have_rtnl_getnsid to false.
> 
> Fixes: d652ccbf8195 ("netns: allow to dump and monitor nsid")
> Signed-off-by: Liping Zhang <liping.zhang@...eadtrum.com>

Makes sense. Applied.