netdev - RE: [PATCH v4 net-next 13/16] tcp: allow congestion control to expand send buffer differently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB0105B1D@AcuExch.aculab.com>
Date:   Wed, 21 Sep 2016 09:25:47 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Stephen Hemminger' <stephen@...workplumber.org>,
        Neal Cardwell <ncardwell@...gle.com>
CC:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Yuchung Cheng <ycheng@...gle.com>,
        Van Jacobson <vanj@...gle.com>,
        Nandita Dukkipati <nanditad@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: RE: [PATCH v4 net-next 13/16] tcp: allow congestion control to
 expand send buffer differently

From: Stephen Hemminger
> Sent: 20 September 2016 18:48
...
> > -	sndmem = 2 * nr_segs * per_mss;
> > +	sndmem = ca_ops->sndbuf_expand ? ca_ops->sndbuf_expand(sk) : 2;
> 
> You could avoid the conditional (if it mattered) by inheriting a default value
> that would mean changing all existing congestion control modules.
> So doing it this way makes life easier.

The indirect call is probably worse than the conditional.

	David