netdev - Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1474555686.23058.108.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Thu, 22 Sep 2016 07:48:06 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

On Thu, 2016-09-22 at 15:41 +0200, Hannes Frederic Sowa wrote:

> I found this during working on the file and actually saw no live issues
> (belonged to another series which I just split up).
> 
> I don't think it is a big issue but wanted the writes to the
> rtnl_msg_handlers array to be strictly serialized. I was working on
> adding this to other places, too. Maybe better for net-next even?

Sure, and you probably could enforce an ASSERT_RTNL() in rtnl_register()
to catch all offenders.