netdev - Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1609221850530.27197@nerf40.vanv.qr>
Date:   Thu, 22 Sep 2016 18:53:50 +0200 (CEST)
From:   Jan Engelhardt <jengelh@...i.de>
To:     Vishwanath Pai <vpai@...mai.com>
cc:     pablo@...filter.org, kaber@...sh.net, kadlec@...ckhole.kfki.hu,
        johunt@...mai.com, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        pai.vishwain@...il.com
Subject: Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to
 support higher pps rates


On Thursday 2016-09-22 18:43, Vishwanath Pai wrote:
>+struct hashlimit_cfg2 {
>+	__u32 mode;	  /* bitmask of XT_HASHLIMIT_HASH_* */
>+	__u64 avg;    /* Average secs between packets * scale */
>+	__u64 burst;  /* Period multiplier for upper limit. */

This would have different sizes between i386 and x86_64,
necessiting additional compat functions. It should be padded
or reordered instead.

>+
>+	/* user specified */
>+	__u32 size;		/* how many buckets */
>+	__u32 max;		/* max number of entries */
>+	__u32 gc_interval;	/* gc interval */
>+	__u32 expire;	/* when do entries expire? */
>+
>+	__u8 srcmask, dstmask;
>+};
>+
>+struct xt_hashlimit_mtinfo2 {
>+	char name[NAME_MAX];
>+	struct hashlimit_cfg2 cfg;
>+
>+	/* Used internally by the kernel */
>+	struct xt_hashlimit_htable *hinfo __attribute__((aligned(8)));
>+};