netdev - Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7918b08-f641-c55b-eb1f-2b7e09d7a853@gmail.com>
Date:   Wed, 21 Sep 2016 20:17:00 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     sean.wang@...iatek.com, john@...ozen.org, davem@...emloft.net
Cc:     nbd@...nwrt.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        andrew@...n.ch, keyhaede@...il.com, objelf@...il.com
Subject: Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through
 TRGMII hardware module

Le 21/09/2016 à 19:33, sean.wang@...iatek.com a écrit :
> From: Sean Wang <sean.wang@...iatek.com>
> 
> By default, GMAC0 is connected to built-in switch called
> MT7530 through the proprietary interface called Turbo RGMII
> (TRGMII). TRGMII also supports well for RGMII as generic external
> PHY uses but requires some slight changes to the setup of TRGMII 
> and doesn't have well support on current driver.
> 
> So this patchset
> 1) provides the slight changes of the setup for RGMII can work
>    through TRGMII
> 2) adds additional setting "trgmii" as PHY_INTERFACE_MODE_TRGMII 
>    about phy-mode on device tree to make GMAC0 distinguish which
>    mode it runs
> 3) changes dynamically source clock, TX/RX delay and interface
>    mode on TRGMII for adapting various link
> 
> Changes since v1:
> - fixed the style of comment which doesn't have a space at 
>    the beginning and end of comment lines
> - add support for phy-mode "trgmii" as PHY_INTERFACE_MODE_TRGMII 
>    into linux/phy.h
> - enhance the Documentation about device tree binding for trgmii
>   which is applicable only for GMAC0 which uses fixed-link

Looks good to me:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks Sean!
-- 
Florian