netdev - Re: [PATCH] net: bcmgenet: Fix EPHY reset in power up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160923140609.GA22965@lunn.ch>
Date:   Fri, 23 Sep 2016 16:06:09 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jaedon Shin <jaedon.shin@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Philippe Reynes <tremyfr@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Fix EPHY reset in power up

On Fri, Sep 23, 2016 at 10:20:04PM +0900, Jaedon Shin wrote:
> The bcmgenet_mii_reset() is always not running in power up sequence
> after 'commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from
> struct net_device")'. This'll show extremely high latency and duplicate
> packets while interface down and up repeatedly.
> 
> For now, adds again a private phydev for mii reset when runs power up to
> open interface.

Hi Jaedon

How does this fix the issue? It sounds like you are papering over the
crack, not truly fixing it.

       Andrew