netdev - Re: [PATCH net v2] ip6_gre: fix flowi6_proto value in ip6gre_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53fca902-c7e6-c216-6366-ba3f483854a0@cogentembedded.com>
Date:   Fri, 23 Sep 2016 23:01:15 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Lance Richardson <lrichard@...hat.com>, netdev@...r.kernel.org
Cc:     shmulik.ladkani@...il.com, jbenc@...hat.com
Subject: Re: [PATCH net v2] ip6_gre: fix flowi6_proto value in
 ip6gre_xmit_other()

Hello.

On 09/23/2016 10:50 PM, Lance Richardson wrote:

> Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in
> xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup.
>
> Up until now, ip6gre_xmit_other() has set flowi6_proto to a bogus value.
> This affected output route lookup for packets sent on an ip6gretap device
> in cases where routing was dependent on the value of flowi6_proto.
>
> Since the correct proto is already set in the tunnel flowi6 template via
> commit 252f3f5a1189 ("ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit
> path."), simply delete the line setting the incorrect flowi6_proto value.
>
> Suggested-by: Jiri Benc <jbenc@...hat.com>
> Fixes: commit c12b395a4664 ("gre: Support GRE over IPv6")

    That "commit" isn't needed here, this tag has a standardized format. 
Hopefully, can be fixed while applying...

> Reviewed-by: Shmulik Ladkani <shmulik.ladkani@...il.com>
> Signed-off-by: Lance Richardson <lrichard@...hat.com>
[...]

MBR, Sergei