lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Sep 2016 10:41:57 +0200 From: Daniel Wagner <wagi@...om.org> To: linux-nfs@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Daniel Wagner <daniel.wagner@...-carit.de>, Anna Schumaker <Anna.Schumaker@...app.com>, Trond Myklebust <trond.myklebust@...marydata.com>, Chuck Lever <chuck.lever@...cle.com>, netdev@...r.kernel.org Subject: [PATCH] xprtrdma: use complete() instead complete_all() From: Daniel Wagner <daniel.wagner@...-carit.de> There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context waker context frwr_op_unmap_sync() reinit_completion() ib_post_send() wait_for_completion() frwr_wc_localinv_wake() complete() Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de> Cc: Anna Schumaker <Anna.Schumaker@...app.com> Cc: Trond Myklebust <trond.myklebust@...marydata.com> Cc: Chuck Lever <chuck.lever@...cle.com> Cc: linux-nfs@...r.kernel.org Cc: netdev@...r.kernel.org --- net/sunrpc/xprtrdma/frwr_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c index 892b5e1..4a24f0e 100644 --- a/net/sunrpc/xprtrdma/frwr_ops.c +++ b/net/sunrpc/xprtrdma/frwr_ops.c @@ -329,7 +329,7 @@ frwr_wc_localinv_wake(struct ib_cq *cq, struct ib_wc *wc) frmr = container_of(cqe, struct rpcrdma_frmr, fr_cqe); if (wc->status != IB_WC_SUCCESS) __frwr_sendcompletion_flush(wc, frmr, "localinv"); - complete_all(&frmr->fr_linv_done); + complete(&frmr->fr_linv_done); } /* Post a REG_MR Work Request to register a memory region -- 2.7.4
Powered by blists - more mailing lists