netdev - Re: [PATCH net] act_ife: Add support for machines with hard_header_len != mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160923.070536.1880911510074184857.davem@davemloft.net>
Date:   Fri, 23 Sep 2016 07:05:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     yotamg@...lanox.com
Cc:     jhs@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] act_ife: Add support for machines with
 hard_header_len != mac_len

From: Yotam Gigi <yotamg@...lanox.com>
Date: Wed, 21 Sep 2016 15:54:13 +0300

> Without that fix, the following could occur:
 ...

I don't think what you are doing in mlxsw is valid.

You can't set hard_header_len arbitrarily, it's the MAC length.

If you need to prepend special headers or whatever, set
->needed_headroom which is designed for this purpose.

Thanks.