lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <19682404.Wm2acsDIf0@wuerfel> Date: Sat, 24 Sep 2016 10:47:25 +0200 From: Arnd Bergmann <arnd@...db.de> To: Baoyou Xie <baoyou.xie@...aro.org> Cc: isdn@...ux-pingi.de, linux-kernel.bfrz@...chmal.in-ulm.de, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, xie.baoyou@....com.cn Subject: Re: [PATCH 3/6] isdn/hisax: add function declarations On Saturday, September 24, 2016 1:21:47 PM CEST Baoyou Xie wrote: > --- a/drivers/isdn/hisax/config.c > +++ b/drivers/isdn/hisax/config.c > @@ -460,42 +460,14 @@ __setup("hisax=", HiSax_setup); > extern int setup_teles0(struct IsdnCard *card); > #endif > > -#if CARD_TELES3 > -extern int setup_teles3(struct IsdnCard *card); > -#endif ... > -#if CARD_TELESPCI > -extern int setup_telespci(struct IsdnCard *card); > -#endif > - > #if CARD_AVM_A1 > extern int setup_avm_a1(struct IsdnCard *card); > #endif It seems odd that you remove some but not all declarations here. Please do all of them at once. > @@ -1350,3 +1350,63 @@ static inline struct pci_dev *hisax_find_pci_device(unsigned int vendor, > } > > #endif > + > +#if CARD_TELES3 > +int setup_teles3(struct IsdnCard *card); > +#endif > + > +#if CARD_TELESPCI > +int setup_telespci(struct IsdnCard *card); > +#endif > + When you add the declarations here, just leave out the #if guards, and put all the declarations here unconditionally, as we normally do in the kernel. Arnd
Powered by blists - more mailing lists