lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CALzJLG8o3dfPJR-2iaWb-s7r65r51HhgTs5Srf92-Tx0sZCSHw@mail.gmail.com> Date: Sat, 24 Sep 2016 13:51:46 +0300 From: Saeed Mahameed <saeedm@....mellanox.co.il> To: Calvin Owens <calvinowens@...com> Cc: Saeed Mahameed <saeedm@...lanox.com>, Matan Barak <matanb@...lanox.com>, Leon Romanovsky <leonro@...lanox.com>, Linux Netdev List <netdev@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, kernel-team@...com Subject: Re: [PATCH] mlx5: Add ndo_poll_controller() implementation On Fri, Sep 23, 2016 at 11:13 PM, Calvin Owens <calvinowens@...com> wrote: > This implements ndo_poll_controller in net_device_ops for mlx5, which is > necessary to use netconsole with this driver. > > Signed-off-by: Calvin Owens <calvinowens@...com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > index 2459c7f..439476f 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > @@ -2786,6 +2786,20 @@ static void mlx5e_tx_timeout(struct net_device *dev) > schedule_work(&priv->tx_timeout_work); > } > > +#ifdef CONFIG_NET_POLL_CONTROLLER > +/* Fake "interrupt" called by netpoll (eg netconsole) to send skbs without > + * reenabling interrupts. > + */ > +static void mlx5e_netpoll(struct net_device *dev) > +{ > + struct mlx5e_priv *priv = netdev_priv(dev); > + int i, nr_sq = priv->params.num_channels * priv->params.num_tc; > + > + for (i = 0; i < nr_sq; i++) > + napi_schedule(priv->txq_to_sq_map[i]->cq.napi); Hi Calvin, Basically all CQs on the same channel are sharing the same napi, so here you will end up calling napi_schedule more than once for each napi (channel). iterating over the SQs map is irrelevant here, all you need to do is to iterate over the channels: for (i = 0; i < priv->params.num_channels; i++) napi_schedule(priv->channel[i]->napi); Thanks, Saeed. > +} > +#endif > + > static const struct net_device_ops mlx5e_netdev_ops_basic = { > .ndo_open = mlx5e_open, > .ndo_stop = mlx5e_close, > @@ -2805,6 +2819,9 @@ static const struct net_device_ops mlx5e_netdev_ops_basic = { > .ndo_rx_flow_steer = mlx5e_rx_flow_steer, > #endif > .ndo_tx_timeout = mlx5e_tx_timeout, > +#ifdef CONFIG_NET_POLL_CONTROLLER > + .ndo_poll_controller = mlx5e_netpoll, > +#endif > }; > > static const struct net_device_ops mlx5e_netdev_ops_sriov = { > @@ -2836,6 +2853,9 @@ static const struct net_device_ops mlx5e_netdev_ops_sriov = { > .ndo_set_vf_link_state = mlx5e_set_vf_link_state, > .ndo_get_vf_stats = mlx5e_get_vf_stats, > .ndo_tx_timeout = mlx5e_tx_timeout, > +#ifdef CONFIG_NET_POLL_CONTROLLER > + .ndo_poll_controller = mlx5e_netpoll, > +#endif > }; > > static int mlx5e_check_required_hca_cap(struct mlx5_core_dev *mdev) > -- > 2.9.3 >
Powered by blists - more mailing lists