lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160923.225102.776369878310265580.davem@davemloft.net> Date: Fri, 23 Sep 2016 22:51:02 -0400 (EDT) From: David Miller <davem@...emloft.net> To: jaedon.shin@...il.com Cc: f.fainelli@...il.com, tremyfr@...il.com, andrew@...n.ch, netdev@...r.kernel.org Subject: Re: [PATCH] Revert "net: ethernet: bcmgenet: use phydev from struct net_device" From: Jaedon Shin <jaedon.shin@...il.com> Date: Sat, 24 Sep 2016 06:08:19 +0900 > This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev > from struct net_device") > > without this patch, we call twice bcmgenet_mii_reset, and that is intended: > - first time from bcmgenet_power_up() to make sure the PHY is initialized > *before* we get to initialize the UniMAC, this is critical > - second time from bcmgenet_mii_probe(), through the normal phy_init_hw() > > with this patch, we only get to call bcmgenet_mii_reset once, in > bcmgenet_mii_probe() because the first time in bcmgenet_power_up(), > dev->phydev is NULL, because of a prior call to phy_disconnect() in > bcmgenet_close(), unfortunately, there has been MAC activity, so the PHY > gets in a bad state > > Signed-off-by: Jaedon Shin <jaedon.shin@...il.com> This is needed by the ksettings commit that happened right after this one, so if you want this reverted you have to revert both commits.
Powered by blists - more mailing lists