lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <49094659-662d-a902-6740-ea3d1fea6660@lwfinger.net> Date: Sat, 24 Sep 2016 11:35:00 -0500 From: Larry Finger <Larry.Finger@...inger.net> To: Joe Perches <joe@...ches.com>, Jean Delvare <jdelvare@...e.de> Cc: Chaoming Li <chaoming_li@...lsil.com.cn>, Kalle Valo <kvalo@...eaurora.org>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages On 09/24/2016 11:15 AM, Joe Perches wrote: > On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: >> Would it make sense to explicitly set the enum values, or add them as >> comments, to make such look-ups easier? > > If you want to create enum->#ENUM structs and > "const char *" lookup functions, please be my guest. > > otherwise, hex is at least a consistent way to display > what should be infrequent output. Displaying those values as hex is OK. As Joe says, they will not be shown very often. I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the drivers, and one that sets the enum values for that particular statement to hex values. I also looked at the other large enums and decided that they never need the human lookup. Larry
Powered by blists - more mailing lists