netdev - Re: [PATCH net-next] Revert "net: ethernet: bcmgenet: use phydev from struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <369f299b-46ab-7d5e-14b4-8044649b41ed@gmail.com>
Date:   Sun, 25 Sep 2016 08:30:34 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, tremyfr@...il.com, jaedon.shin@...il.com
Subject: Re: [PATCH net-next] Revert "net: ethernet: bcmgenet: use phydev from
 struct net_device"

Le 25/09/2016 à 02:35, David Miller a écrit :
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Sat, 24 Sep 2016 20:06:12 -0700
> 
>> This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev
>> from struct net_device") because it causes GENETv1/2/3 adapters to
>> expose the following behavior after an ifconfig down/up sequence:
> 
> This breaks the conversion of this driver to ethtool ksettings.

I must be missing something here, the proposed patch passes priv->phydev
to the ethtool ksettings helpers, is there something else that needs to
be taken care of?

Sorry for being slow to understand here...
-- 
Florian